Add recommended extensions for VSCode #5233 #5237
Conversation
Add recommended extension for vs code
gigitux
added
type: enhancement
rubikuserbot
requested review from
a team and
dinhtungdu
and removed request for
a team
|
Size Change: +1.99 kB (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
@gigitux We already have a section on recommended extensions here. Personally, I just use a few extensions listed above. It's not a good developer experience to me if I install recommended extensions then have to remove some of them manually. It's also hard to debug when there is something unexpected caused by one extension in many recommended extensions I've just installed.
On the other hand, in your PR, you remove .vscode from the ignore file. That folder may contain many other local/project-specific files. So I don't think we should whitelist it. I'm not sure about other people's workflow, but for WordPress themes/plugins development, I add the WordPress root dir to the workspace, not the plugin folder, so the recommendation here may not work in that case.
|
@dinhtungdu Thanks for your feedback!
Before installing the recommended extensions, you can review them and decide not to install them. It's just to speed up the onboarding for the newcomers.
These extensions were chosen after getting some opinions from other folks in the team about what extensions they use.
|
There was a problem hiding this comment.
@gigitux The recommendation doesn't show for me. I have some but not all of the recommended extensions installed. When I check the extension tab, I see some extensions not in our list but appear in the Recommended section. Please check the screencast for more detail.
Screen.Recording.2021-11-30.at.16.09.55.mov
|
Also, I'm not sure about the benefit of this PR in real use-cases, given that we're developing a WordPress plugin.
|
Maybe it doesn't show you because you already closed the dialog in the past or for your VSCode configuration. Check the attached video to check what should happen when a user opens for the first time our project. Another way to check that everything is okay is to open the extension section and write in the search box
trim_YZA6HU.mp4 |
) * Add recommended extension for vs code woocommerce#5233 Add recommended extension for vs code * replace PHP extensions * add editor config extension * update gitignore
) * Add recommended extension for vs code woocommerce#5233 Add recommended extension for vs code * replace PHP extensions * add editor config extension * update gitignore
This PR helps the onboarding experience for a new user that wants to contribute to this repo.
The recommended extensions are:
Fixes #5233
Testing
How to test the changes in this Pull Request:
Check out this branch