Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Display decimals if intended by the merchant #5219

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

nielslange
Copy link
Member

@nielslange nielslange commented Nov 23, 2021

Fixes #5019

Testing

Automated Tests

  • Changes in this PR are covered by Automated Tests.
    • Unit tests
    • E2E tests

Run the following command in the terminal:

npm run test -i packages/prices/utils/test/price.js

Manual Testing

Test $0 price

  1. Create a test page, add the mini cart block and save it.
  2. Open the mini cart page in the frontend.
  3. See that the price shows $0.00.
  4. Hover over the price and verify that it remains $0.00.

Test $50 price

  1. Add product(s) to the cart with a value of $50.
  2. Open the mini cart page in the frontend.
  3. See that the price shows $50.00.
  4. Hover over the price and verify that it remains $50.00.

User Facing Testing

These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).

  • Same as above
  • See steps below

Changelog

Ensure that expected numbers of decimals are visible, if wanted my the merchant, even if the price is $0 or has no decimals, such as $50.

@nielslange nielslange added type: bug The issue/PR concerns a confirmed bug. block: mini-cart Issues related to the Mini-Cart block. labels Nov 23, 2021
@rubikuserbot rubikuserbot requested review from a team and senadir and removed request for a team November 23, 2021 12:58
@nielslange nielslange requested review from mikejolley and removed request for senadir November 23, 2021 12:59
@nielslange nielslange added this to the 6.5.0 milestone Nov 23, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2021

Size Change: +31 B (0%)

Total Size: 1.04 MB

Filename Size Change
build/price-format.js 1.19 kB +31 B (+3%)
ℹ️ View Unchanged
Filename Size
build/active-filters-frontend.js 6.23 kB
build/active-filters.js 7.09 kB
build/all-products-frontend.js 22.1 kB
build/all-products.js 32.9 kB
build/all-reviews.js 8.3 kB
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 2.76 kB
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 1.48 kB
build/atomic-block-components/add-to-cart-frontend.js 6.87 kB
build/atomic-block-components/add-to-cart.js 6.44 kB
build/atomic-block-components/button-frontend.js 1.48 kB
build/atomic-block-components/button.js 851 B
build/atomic-block-components/category-list-frontend.js 457 B
build/atomic-block-components/category-list.js 456 B
build/atomic-block-components/image-frontend.js 1.38 kB
build/atomic-block-components/image.js 1.05 kB
build/atomic-block-components/price-frontend.js 1.75 kB
build/atomic-block-components/price.js 1.71 kB
build/atomic-block-components/rating-frontend.js 553 B
build/atomic-block-components/rating.js 554 B
build/atomic-block-components/sale-badge-frontend.js 626 B
build/atomic-block-components/sale-badge.js 623 B
build/atomic-block-components/sku-frontend.js 385 B
build/atomic-block-components/sku.js 386 B
build/atomic-block-components/stock-indicator-frontend.js 584 B
build/atomic-block-components/stock-indicator.js 584 B
build/atomic-block-components/summary-frontend.js 874 B
build/atomic-block-components/summary.js 875 B
build/atomic-block-components/tag-list-frontend.js 458 B
build/atomic-block-components/tag-list.js 458 B
build/atomic-block-components/title-frontend.js 1.11 kB
build/atomic-block-components/title.js 1.11 kB
build/attribute-filter-frontend.js 16.3 kB
build/attribute-filter.js 10.8 kB
build/blocks-checkout.js 20.8 kB
build/cart-blocks/accepted-payment-methods-frontend.js 1.14 kB
build/cart-blocks/checkout-button-frontend.js 1.14 kB
build/cart-blocks/empty-cart-frontend.js 345 B
build/cart-blocks/express-payment-frontend.js 4.82 kB
build/cart-blocks/filled-cart-frontend.js 768 B
build/cart-blocks/items-frontend.js 298 B
build/cart-blocks/line-items-frontend.js 5.13 kB
build/cart-blocks/order-summary-frontend.js 8.95 kB
build/cart-blocks/totals-frontend.js 320 B
build/cart-frontend.js 48.9 kB
build/cart.js 44.5 kB
build/checkout-blocks/actions-frontend.js 1.44 kB
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 4.33 kB
build/checkout-blocks/billing-address-frontend.js 889 B
build/checkout-blocks/contact-information-frontend.js 2.94 kB
build/checkout-blocks/express-payment-frontend.js 5.11 kB
build/checkout-blocks/fields-frontend.js 343 B
build/checkout-blocks/order-note-frontend.js 1.13 kB
build/checkout-blocks/order-summary-frontend.js 11.4 kB
build/checkout-blocks/payment-frontend.js 7.5 kB
build/checkout-blocks/shipping-address-frontend.js 976 B
build/checkout-blocks/shipping-methods-frontend.js 4.89 kB
build/checkout-blocks/terms-frontend.js 1.22 kB
build/checkout-blocks/totals-frontend.js 322 B
build/checkout-frontend.js 51 kB
build/checkout.js 47.5 kB
build/featured-category.js 6.66 kB
build/featured-product.js 8.01 kB
build/handpicked-products.js 5.37 kB
build/legacy-template.js 2.05 kB
build/mini-cart-component-frontend.js 40.6 kB
build/mini-cart-contents.js 1.81 kB
build/mini-cart-frontend.js 1.74 kB
build/mini-cart.js 5.95 kB
build/price-filter-frontend.js 12.1 kB
build/price-filter.js 8.61 kB
build/product-best-sellers.js 5.57 kB
build/product-categories.js 2.91 kB
build/product-category.js 6.44 kB
build/product-new.js 5.73 kB
build/product-on-sale.js 6.11 kB
build/product-search.js 2.47 kB
build/product-tag.js 5.81 kB
build/product-top-rated.js 5.7 kB
build/products-by-attribute.js 6.62 kB
build/reviews-by-category.js 9.94 kB
build/reviews-by-product.js 11 kB
build/reviews-frontend.js 7.21 kB
build/single-product-frontend.js 25.5 kB
build/single-product.js 8.51 kB
build/stock-filter-frontend.js 6.51 kB
build/stock-filter.js 6.81 kB
build/vendors--atomic-block-components/add-to-cart--cart-blocks/order-summary--checkout-blocks/billing-ad--c5eb4dcd-frontend.js 16.1 kB
build/vendors--atomic-block-components/add-to-cart-frontend.js 4.45 kB
build/vendors--atomic-block-components/price--cart-blocks/line-items--cart-blocks/order-summary--checkout--8a3571de-frontend.js 5.71 kB
build/vendors--cart-blocks/line-items--checkout-blocks/order-summary-frontend.js 3.14 kB
build/vendors--cart-blocks/order-summary--checkout-blocks/billing-address--checkout-blocks/order-summary---eb4d2cec-frontend.js 5.02 kB
build/wc-blocks-data.js 8.84 kB
build/wc-blocks-editor-style-rtl.css 15.8 kB
build/wc-blocks-editor-style.css 15.8 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 949 B
build/wc-blocks-registry.js 2.69 kB
build/wc-blocks-shared-context.js 1.51 kB
build/wc-blocks-shared-hocs.js 1.14 kB
build/wc-blocks-style-rtl.css 21.1 kB
build/wc-blocks-style.css 21.1 kB
build/wc-blocks-vendors-style-rtl.css 1.37 kB
build/wc-blocks-vendors-style.css 1.37 kB
build/wc-blocks-vendors.js 255 kB
build/wc-blocks.js 2.95 kB
build/wc-payment-method-bacs.js 820 B
build/wc-payment-method-cheque.js 816 B
build/wc-payment-method-cod.js 912 B
build/wc-payment-method-paypal.js 838 B
build/wc-payment-method-stripe.js 10.9 kB
build/wc-settings.js 2.58 kB

compressed-size-action

packages/prices/utils/test/price.js Show resolved Hide resolved
packages/prices/utils/price.ts Outdated Show resolved Hide resolved
packages/prices/utils/price.ts Show resolved Hide resolved
packages/prices/utils/price.ts Show resolved Hide resolved
@nielslange nielslange force-pushed the fix/5019-apply-decimals branch from ba7e704 to 83b43f8 Compare November 23, 2021 17:00
@nielslange
Copy link
Member Author

Thanks for your review, @mikejolley! 🙌

@nielslange nielslange merged commit 10dab1e into trunk Nov 24, 2021
@nielslange nielslange deleted the fix/5019-apply-decimals branch November 24, 2021 13:21
jonny-bull pushed a commit to jonny-bull/woocommerce-gutenberg-products-block that referenced this pull request Dec 14, 2021
jonny-bull pushed a commit to jonny-bull/woocommerce-gutenberg-products-block that referenced this pull request Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: mini-cart Issues related to the Mini-Cart block. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

formatPrice strips decimals
2 participants