This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Re-add experimental discounts meta slot to checkout #5149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
type: bug
rubikuserbot
requested review from
a team and
ralucaStan
and removed request for
a team
|
Size Change: +35 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
nielslange
added
the
status: blocker
ralucaStan
approved these changes
Nov 16, 2021
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
|
I noticed a small visual bug in the Cart block and I opened another issue for it. |
|
Thanks Raluca, maybe we should move that to the Points and Rewards repo since this isn't an issue with Blocks but with P&R's css :) |
@opr I am not sure it should be moved because I went back to an older commit in our repo and the form looked well. |
Hm OK! Let's look into it then, thanks Raluca :) |
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the
<ExperimentalDiscountsMeta.Slot { ...discountsSlotFillProps } />was removed from the Checkout Order Summary.This breaks the Points and Rewards integration.
cc @layoutd thanks for reporting this :)
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
WooCommerce > Points and Rewardsand add points to your user.WooCommerce > Points and Rewards > Settingsand enable "Allow partial redemption"User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).