This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add version to doing it wrong calls #5134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
the
skip-changelog
rubikuserbot
requested review from
a team and
ralucaStan
and removed request for
a team
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some environments report an error when
_doing_it_wrongis called without a$version. This PR adds a version to each call to mitigate.Fixes #5074
I used
4.6.0for the missing versions which was the version this PR was part of which last touched them.Testing
These are only triggered by integrations that are doing something wrong, so there is nothing user-facing to test here and just requires code review.