This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Remove feature gate conditions for Store Editing Templates BlockTemplatesController #5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
Aljullu
and removed request for
a team
November 11, 2021 12:56
tjcafferkey
added
focus: FSE
Work related to prepare WooCommerce for FSE.
focus: template
Related to API powering block template functionality in the Site Editor
labels
Nov 11, 2021
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
Aljullu
approved these changes
Nov 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nielslange
added
the
skip-changelog
PRs that you don't want to appear in the changelog.
label
Nov 15, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
focus: FSE
Work related to prepare WooCommerce for FSE.
focus: template
Related to API powering block template functionality in the Site Editor
skip-changelog
PRs that you don't want to appear in the changelog.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the feature gate for the BlockTemplatesController class. This is required before release.
Fixes #5127
Manual Testing
How to test the changes in this Pull Request:
We need to regression test the project to ensure it still loads as expected. You can do this choosing your own method(s) or follow the instructions below.
Before doing so please check the the Project Testing Notes here
/wp-admin/themes.php?page=gutenberg-edit-site&postId=woocommerce%2F%2Fsingle-product&postType=wp_template
Changelog