This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Add global styles to Product Title block #5009
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinhtungdu
added
focus: global styles
Issues that involve styles/css/layout structure.
type: enhancement
The issue is a request for an enhancement.
block-type: product elements
Issues related to Product Element blocks.
status: needs review
labels
Oct 27, 2021
…m:woocommerce/woocommerce-gutenberg-products-block into add/4919-global-style-product-title-block
Size Change: +716 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I left one minor comment, but once fixed, let's merge it, it's great to be able to remove almost a hundred lines! 🥳
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Oct 28, 2021
Wondering if we should add the |
dinhtungdu
added
the
skip-changelog
PRs that you don't want to appear in the changelog.
label
Oct 28, 2021
Co-authored-by: Albert Juhé Lluveras <[email protected]>
18 tasks
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
Co-authored-by: Albert Juhé Lluveras <[email protected]>
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
Co-authored-by: Albert Juhé Lluveras <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block-type: product elements
Issues related to Product Element blocks.
focus: global styles
Issues that involve styles/css/layout structure.
skip-changelog
PRs that you don't want to appear in the changelog.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4919
This PR:
apiVersion: 2
.Screenshots
Block setting:
Global style:
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
trunk
commit.All Products
block to a post or page.Changelog