This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
mikejolley
and removed request for
a team
October 21, 2021 09:49
ralucaStan
added
the
skip-changelog
PRs that you don't want to appear in the changelog.
label
Oct 21, 2021
Size Change: +392 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
mikejolley
approved these changes
Oct 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks good 👍🏻
Since this is smaller than scope from the i1-i2 migration, I'd suggest holding off merging and rebasing once thats merged to trunk.
@mike agree on the merge part |
ralucaStan
added
the
status: blocked
The issue is blocked from progressing, waiting for another piece of work to be done.
label
Oct 21, 2021
We use CSS and the is-loading class to hide empty state and show regular state
ralucaStan
force-pushed
the
update/cart-i2-loading-state
branch
from
October 25, 2021 15:03
91a1e0c
to
63cd8fa
Compare
senadir
approved these changes
Oct 25, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* Add a loading state to Cart i2 We use CSS and the is-loading class to hide empty state and show regular state * Lint cart/style.scss
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
* Add a loading state to Cart i2 We use CSS and the is-loading class to hide empty state and show regular state * Lint cart/style.scss
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: cart
Issues related to the cart block.
skip-changelog
PRs that you don't want to appear in the changelog.
status: blocked
The issue is blocked from progressing, waiting for another piece of work to be done.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use CSS and the is-loading class to hide the empty state and show a loading state for the filled state.
Fixes #4964
How to test the changes in this Pull Request: