This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add custom className support to Checkout Inner Blocks #4978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
opr
and removed request for
a team
mikejolley
commented
Oct 20, 2021
|
|
||
| const Main = ( { children, className } ) => { | ||
| const Main = forwardRef( ( { children, className = '' }, ref ) => { |
There was a problem hiding this comment.
This allowed me to combine 2 wrapper divs into one (functional components do not support refs so we need to forward to the div).
|
Size Change: +811 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
|
@senadir Should I avoid |
senadir
reviewed
Oct 20, 2021
| @@ -86,6 +90,7 @@ export const Edit = ( { | |||
| <Block | |||
| showReturnToCart={ showReturnToCart } | |||
| cartPageId={ cartPageId } | |||
| className={ className } | |||
There was a problem hiding this comment.
Classname should exist on the useBlockProps here right?
Package? it's pretty lightweight and we already use it. |
senadir
approved these changes
Oct 20, 2021
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* Pass classname from DOM to react components * Actions Block ClassName support * Form step field classname support * Payment block className support * Classname support for fields and totals * Order summary classname support * Classname support for order note block * Express payment classname support * Terms block custom class * Let useBlockProps handle class in actions block
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
* Pass classname from DOM to react components * Actions Block ClassName support * Form step field classname support * Payment block className support * Classname support for fields and totals * Order summary classname support * Classname support for order note block * Express payment classname support * Terms block custom class * Let useBlockProps handle class in actions block
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
renderInnerBlocksto pass the className to our components, and then adds classname support to all checkout inner blocks.Fixes #4963
Testing
How to test the changes in this Pull Request:
Changelog