This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Store API - Force states to an array type #4975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
type: bug
rubikuserbot
requested review from
a team and
senadir
and removed request for
a team
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
senadir
approved these changes
Oct 20, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an issue with notices being thrown in the Store API when testing on @ralucaStan's install. When a country has no states,
wc()->countries->get_statesreturns a boolean.count()returns 1 which breaks the logic.This PR casts the boolean to an array so
count()works as expected.Introduced in #4844
Testing
How to test the changes in this Pull Request:
If you checkout and set the address to a country with no states, e.g. United Kindom, you'll see warnings in your logs:
Clear the logs after applying this fix and retest. Check logs are clean.