This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Don't fire woocommerce_blocks_loaded if WC version is not met #4873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senadir
added
status: blocker
senadir
added
type: dependencies
nerrad
approved these changes
Sep 30, 2021
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
frontdevde
approved these changes
Sep 30, 2021
senadir
added a commit
that referenced
this pull request
Sep 30, 2021
senadir
added a commit
that referenced
this pull request
Oct 5, 2021
* Empty commit for release pull request * add testing notes * Don't fire woocommerce_blocks_loaded if WC version is not met (#4873) * add testing zip * revert to WC 5.6 as min supported version * Bumping version strings to new version. Co-authored-by: github-actions <[email protected]> Co-authored-by: Nadir Seghir <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fire
woocommerce_blocks_loadedfor 3P plugins that integrate with us as a safe way to signal that WooCommerce Blocks has loaded. However, we didn't properly bail out from firing it if the WooCommerce required version is not met.This PR changes that so we only fire init and woocommerce_blocks_loaded if the version is met. I also scanned the rest of the code in that file to make sure we're not returning when we should be bailing.
Testing steps
SchemaControllernot being available.Changelog