Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove blocks API endpoints #477

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Remove blocks API endpoints #477

merged 2 commits into from
Mar 6, 2019

Conversation

ryelle
Copy link
Member

@ryelle ryelle commented Mar 6, 2019

Part of the breaking changes we're making to this plugin is to remove the API endpoints now that they'll be available in WC 3.6. This PR removes those endpoint files, so we only have the endpoints defined in one place 👍

How to test the changes in this Pull Request:

There should be no functional changes if you're using the add/blocks-rest-api branch of WooCommerce.

@ryelle ryelle added [Status] Needs Review focus: rest api Work impacting REST api routes. labels Mar 6, 2019
@ryelle ryelle added this to the 2.0 + Core Merge milestone Mar 6, 2019
@ryelle ryelle self-assigned this Mar 6, 2019
@ryelle ryelle requested a review from a team March 6, 2019 19:15
@timmyc
Copy link
Contributor

timmyc commented Mar 6, 2019

Looks like we might need to remove the tests too? https://github.com/woocommerce/woocommerce-gutenberg-products-block/tree/master/tests/api

Copy link
Contributor

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the feature branch and all is good. Thinking once the api tests are removed this is good to merge. Pre-approving.

@ryelle ryelle merged commit 02ec9db into master Mar 6, 2019
@ryelle ryelle deleted the remove/blocks-api branch March 6, 2019 21:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: rest api Work impacting REST api routes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants