This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Define parent in registerCheckoutBlock #4591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
status: needs review
skip-changelog
|
Size Change: +7 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
mikejolley
force-pushed
the
fix/register-checkout-block-parent
branch
from
f461fd5 to
a3ec41c
Compare
senadir
reviewed
Aug 18, 2021
| if ( options?.configuration ) { | ||
| assertOption( options, 'configuration', 'object' ); | ||
| registerExperimentalBlockType( blockName, { | ||
| ...options.configuration, | ||
| category: 'woocommerce', | ||
| parent: [], |
There was a problem hiding this comment.
Can't we extrapolate this from options.areas?
There was a problem hiding this comment.
It doesn't seem like we need to. Those areas still work.
There was a problem hiding this comment.
I'm not sure I understand?
I mean that instead of waiting for 3PD to pass the parent value, we implicitly provide it from what's in options.areas
There was a problem hiding this comment.
Parent should be empty. We're not accepting this prop from 3PD, it's being overwritten as [].
3PD use the area prop to define where they want blocks to appear. Not parent.
There was a problem hiding this comment.
Ah right, sorry. My understanding is that having [] would disable the block from all inserters.
I don't understand yet how can we show sample block only on our innerBlocks, is it because allowedBlocks override parent?
There was a problem hiding this comment.
Yup it certainly looks that way. My testing instructions cover this—sample block can be inserted into the contact information section.
There was a problem hiding this comment.
Yeah, I can see that. Approved.
senadir
approved these changes
Aug 18, 2021
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
registerCheckoutBlockto include an emptyparentproperty. This ensures a block registered viaregisterCheckoutBlockis only available in defined areas, not globally.Fixes #4492
How to test the changes in this Pull Request:
npm start).