This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Replace new lines with empty strings when outputting category list #4587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because br tags are being added because of linebreaks in the string. If we replace the linebreaks with empty strings they won't be converted into br elements.
opr
added
status: needs review
type: bug
The issue/PR concerns a confirmed bug.
block: product categories list
Issues related to the Product Categories List block.
priority: high
The issue/PR is high priority—it affects lots of customers substantially, but not critically.
labels
Aug 16, 2021
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
senadir
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well.
I'm seeing parentheses, even though you reverted them? not sure why.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Aug 18, 2021
nerrad
changed the title
Replace new lines with empty strings when outputting catgeory list
Replace new lines with empty strings when outputting category list
Aug 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: product categories list
Issues related to the Product Categories List block.
priority: high
The issue/PR is high priority—it affects lots of customers substantially, but not critically.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will replace new lines in the Product Category List block with empty strings before rendering it.
This is because the code is written in such a way that newlines end up in the string, these eventually end up parsing into
<br>
elements.If the new lines are removed, no
<br>
elements are added.This PR also moves the text within the
<a>
onto the same line, to remove excess spaces from the string.Finally, the product count is also enclosed in parentheses, so it matches the preview in the block editor.
Fixes #4577
Screenshots
How to test the changes in this Pull Request:
Product Category List
block to a page.Changelog