-
Notifications
You must be signed in to change notification settings - Fork 219
Add Mini Cart block in experimental builds #4510
Conversation
Size Change: +40.6 kB (+4%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
Besides the non-blocking improvements this PR suggest is possible, would you be able to get some performance metrics using performance tab in Google Chrome (I think you can measure Web Vitals now there too) to get some idea of the impact between non-lazy and lazy loaded? |
I quickly created a new branch that removes the lazy-loading ( With lazy loading:
Without lazy loading:
Then, I applied a Network throttling of With lazy loading:
Without lazy loading:
What's interesting is that Largest Contentful Paint doesn't seem to change when lazy loading is enabled or not. However, differences in DOMContentLoaded and the load event look quite big. |
3e2a464
to
c93cc4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Albert, really nice work in this commit. I left some comments, my focus was mostly on the FE part, so I recommend another 👀 for the PHP side.
Thanks for reviewing this @ralucaStan. I applied your feedback (except a couple of comments that I leave for #4608). Let me know how everything looks now. |
81781f7
to
b38f669
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the comments. Really nice work! 👏
Part of #4138 and #4245.
This PR adds to the experimental builds an initial version of a MiniCart block which has the following characteristics:
The benefits of this approach are:
This approach was discussed in pca54o-1PL-p2 (conclusions can be found in #4245 (comment)).
How to test the changes in this Pull Request:
This PR is an initial step, so don't expect the block to look or work perfectly. UI, interactions, etc. will be improved in subsequent PRs. This epic has some of the next steps we will be working on: #4138.