This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[Store Customization] Update the "Footer with 3 Menus" pattern to remove the last 2 menus #11980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
added
type: enhancement
woocommercebot
requested review from
a team and
kmanijak
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.53 MB ℹ️ View Unchanged
|
kmanijak
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
It looks good, duplicated menus are gone! 🚀
I know it's just an initial step before exploring if unique menus can be created but at the moment pattern's name is a bit inadequate mentioning 3 menus while there's just one. We may want to:
- temporarily change the pattern name (we could keep the slug though),
- temporarily hide the pattern from inserter.
I don't have a strong opinion and maybe that's really unnecessary step so I'm pre-approving! 🙌
Good catch @kmanijak I've done this 👌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR removes the last 2 columns and menus on the "Footer with 3 Menus" pattern.
Why
As discussed on p1701229495243029/1700666170.703699-slack-C053716F2H2 this is the first step to avoid duplication while we add more pages and are able to have 3 different menus.
Fixes #11847
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog