This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Store Customization > Ensure the price for products is also AI-generated #11859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
albarin
added
type: enhancement
|
Size Change: +1.77 kB (0%) Total Size: 1.61 MB
ℹ️ View Unchanged
|
nefeline
reviewed
Nov 21, 2023
There was a problem hiding this comment.
Great job @albarin ! Confirmed the price is being generated by AI as expected.
One caveat: when I added the prompt for selling cars, for example, I still got some prices that were very low (I mean, I would be super happy to buy an Audi for 500 euros :D )
I wonder where the currency is coming from as well: maybe we should make some additional changes to ensure the currency matches whatever the store owner selected as the currency for their store: WDYT?
Good point! I've tweaked the prompt to include the store currency and to try to use a price that makes sense with the product. It does not work 100% of the times, but I think it's an improvement. Let me know what you think. |
nefeline
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Hey @albarin ! Thanks for addressing the feedback: confirmed it works as expected with a few examples:
It does not work 100% of the times, but I think it's an improvement. Let me know what you think.
Yeah, I think we can do some fine-tuning to the prompt here. If I'm not mistaken, I think folks from woo-ai also have a prompt they created for generating the price for products: might be worth checking the codebase or reaching out to them to confirm!
I'm going ahead and approving this PR: feel free to either fine-tune the prompt here or on a separate/new PR: whatever you prefer 👍
Okay, I wasn't aware of that. I will merge this PR and investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR updates the product generation AI prompt to also generate the product price.
Why
Fixes #11828
Before, we were generating the prices randomly between 5 and 50, which produced some weird results. This way we ensure the prices makes sense with the product
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Setup
Please test the feature on a WooExpress install instead of Jurassic Ninja, as the latter can be very limited in terms of server resources and unstable, as other installs can interfere with your own.
woocommerce.zip
/wp-admin/tools.php?page=woocommerce-admin-test-helperand enablecustomize-storefeature flag:Test the CYS experience
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).