This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Remove bullet points and unnecessary padding from SearchListControl
#11444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunyatasattva
added
block: single product
Issues related to the single product block.
block: featured category
Issues related to the Featured Category block,
block: featured product
Issues related to the Featured Product block.
focus: global styles
Issues that involve styles/css/layout structure.
type: compatibility
labels
Oct 25, 2023
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
October 25, 2023 09:59
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: +17 B (0%) Total Size: 1.53 MB
ℹ️ View Unchanged
|
albarin
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
@albarin 😂 Review comes even before CI finishes! 😪 Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: featured category
Issues related to the Featured Category block,
block: featured product
Issues related to the Featured Product block.
block: single product
Issues related to the single product block.
focus: global styles
Issues that involve styles/css/layout structure.
type: compatibility
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
On certain themes (such as TT1 and TT4) the
SearchListControl
used in blocks such as Single Product, Featured Product and Featured Category, might display traditional bullet list style and padding. This PR fixes that.Fixes #11327, #10348
References #11299
Testing Instructions
Screenshots or screencast
|
| |
WooCommerce Visibility
Required:
Checklist
Required:
[type]
label or a[skip-changelog]
label.Conditional:
[skip-changelog]
label is not present).Changelog