This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove authors filter from Product Collection block #11427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
added
type: enhancement
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -336 B (0%) Total Size: 1.53 MB
ℹ️ View Unchanged
|
imanish003
approved these changes
Oct 25, 2023
kmanijak
deleted the
remove/11002-remove-authors-filter-from-product-collection
branch
Merged
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove
authorsfilter from Product Collection block.Fixes #11002
Why
From original issue #11002:
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Go to Editor
Add Product Collection block
Disable "Inherit query from template"
Make sure there's no "Authors" filter available in the Inspector Controls
Smoke test the Product Collection in the Editor and Frontend
Go to Editor
Add Products (Beta) block
Disable "Inherit query from template"
Add couple of product filters (for example Sale Status and Attributes)
Click "Upgrade to Product Collection" in Inspectopr Controls
Make sure Product Collection preserved the filters and works correctly after migration
Save and check the frontend.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog