This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Improve 'hero product 3 split' pattern #11414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: enhancement
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.53 MB ℹ️ View Unchanged
|
Given the restrictions we have on development for mobile view, we need to evaluate what's possible and what isn't possible here (and perhaps update the designs to account for a better layout). Tagging @verofasulo for her opinion here. |
@nefeline @gigitux I'm not sure about what screenshot we're referring to. |
We are referring to this screenshot:
The admin menubar is a bug of the tool screenshot. Please, check the text on the left column: it is not aligned with the image. |
I was thinking specifically about this pattern when I said this in this thread: [...] one of them is for sure the fact that some of them have not been designed with a clear idea of the many constraints that we have in the editor. This ends up in very weird layouts as soon as we resize the screen. In an ideal world, I think the best option would be to review them, simplify the design as the first step, and carefully implement spacing and text styles [...] The design is too complicated 🥲 Do you think something like this might help?
I removed the first column and moved the title and the Specs:
|
13 tasks
|
Closing this issue in favor of #11495 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11398.
This PR improves:
Why
For fixing the mobile view (put the text on top and after the image), it has been necessary not to use the Media & Text block.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Hero Product 3 splitpattern.Warning
I noticed that in the "tablet view" the current pattern doesn't look great. Should we address this in the current iteration? The screenshot below was taken with the Pixel 5 viewport in horizontal mode.
Screenshots or screencast
Mockup
Implementation
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog