This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Move SortSelect to components package
#11411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
status: needs review
type: enhancement
woocommercebot
requested review from
a team and
tarhi-saad
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
opr
changed the title
SortSelect to components package
opr
force-pushed
the
update/move-sortselect
branch
from
9b8848a to
ca186b6
Compare
|
Size Change: -1.39 kB (0%) Total Size: 1.53 MB
ℹ️ View Unchanged
|
opr
commented
Oct 23, 2023
assets/js/base/components/index.ts
Outdated
| export * from './formatted-monetary-amount'; | ||
| export * from './label'; |
There was a problem hiding this comment.
I think these were missed during a rebase of the other PRs, so including them here.
tarhi-saad
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Thank you, @opr, for working on this PR! Everything looks good! There are only some conflicts in this branch that must be resolved!
opr
force-pushed
the
update/move-sortselect
branch
from
ca186b6 to
ec277c9
Compare
opr
added a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Move
SortSelectcomponent to components package and update the places it is imported:ProductSortSelectReviewSortSelectPropsWhy
As more developers integrate their extensions with WooCommerce Blocks, the case for reusing components grows. This starts the ball rolling by creating a new package. Rather than recreating components developers can access
wc.blocksComponentsand get the ones we need.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog