This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add: menu-order orderby option for Product Attribute Terms route
#11232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
dinhtungdu
added
status: needs review
type: enhancement
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +104 B (0%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
mikejolley
approved these changes
Oct 16, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Co-authored-by: Mike Jolley <[email protected]>
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds a new
orderbyoption callmenu_orderto Product Attribute Terms route to allow attribute terms can be sorted by custom ordering. WooCommerce sort the attribute terms by custom ordering by default but the API sorts terms by name by default. This API won't change that behavior.This PR also update the Attribute Filter block to get query attribute terms sorted by custom ordering.
Fixes #11219
Why
See #11219.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog