This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[Store Customization MVP] Add fallbacks to all the pattern titles, descriptions and buttons #11208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
added
type: enhancement
albarin
force-pushed
the
11166/add-patterns-fallback
branch
from
e040113 to
6531f2f
Compare
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.48 MB ℹ️ View Unchanged
|
albarin
changed the title
|
There was no PHP errors in my error log, however I noticed some issues with a few patterns. Some may be a result of this PR, others may not be:
|
|
@tjcafferkey Regarding About the I've removed the pagination in |
|
|
tjcafferkey
approved these changes
Oct 12, 2023
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds fallbacks to all the pattern titles, descriptions and buttons.
Part of #11166
Why
To avoid a PHP warning that could be triggered if certain parts of the content for the pattern don't exist on the AI-generated content within the 'wc_blocks_patterns_content' option yet.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
dictionary.jsonfile.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog