This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Increase number of visible products when cart is empty #11182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
type: bug
woocommercebot
requested review from
a team and
wavvves
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.48 MB ℹ️ View Unchanged
|
nielslange
force-pushed
the
fix/11058-number-of-visible-products-on-empty-cart
branch
from
26bd20b to
2c71095
Compare
wavvves
approved these changes
Oct 9, 2023
|
Thanks for reviewing this PR, @wavvves! |
nielslange
deleted the
fix/11058-number-of-visible-products-on-empty-cart
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Increase the number of visible products when the cart is empty.
Fixes #11058
Why
While the Twenty Twenty-Three theme sets
.alignwideto1200px, which renders the product images in a width of450px, the Twenty Twenty-Four theme sets.alignwideto1280pxrendering the product images in a width of300px. This leads to gaps between the product images and causes the sales badge to be visible next to the product image instead of within it.In p1696841688418399-slack-C02UBB1EPEF, @gigitux and @kmanijak suggested using the Product Collection block instead of the Newest Products block, which is showing the issue. Apart from addressing the initial issue, and alternative approach would be to increase the number of visible products, when the cart is empty, from three to four. This reduces the gap between the product images, resulting in the sales badge showing as expected. As the Product Collection block is still in beta, and we would rather not relocate resources to the Newest Products block, given that this block might be deprecated in the future. In pca54o-6sH-p2#comment-5830, @pmcpinto and I agreed on increasing the number of visible products. This change will only affect new installations, but not existing stores.
Testing Instructions
Filled CarttoEmpty Cart.Screenshots or screencast
WooCommerce Visibility
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog