This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Store Customization > Replace patterns based on the Products (Beta) block with an equivalent based on the Product Collection block #11134
Merged
nefeline
merged 12 commits into
trunk
from
11132-store-customization-replace-all-patterns-based-on-the-products-beta-block-with-an-equivalent-based-on-the-product-collection-block
Oct 5, 2023
Merged
Store Customization > Replace patterns based on the Products (Beta) block with an equivalent based on the Product Collection block #11134
nefeline
merged 12 commits into
trunk
from
11132-store-customization-replace-all-patterns-based-on-the-products-beta-block-with-an-equivalent-based-on-the-product-collection-block
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt for 1:1 Image 4-Column Product Row
…nt for Minimal 5-Column Product Row
…nt for 3-Column Product Row
…tern as a replacement for Featured Products 5-Item Grid
nefeline
added
type: enhancement
The issue is a request for an enhancement.
focus: patterns
WooCommerce patterns
block: product collection
Issues related to the Product Collection block
labels
Oct 4, 2023
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
This was referenced Oct 4, 2023
albarin
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I just left a small comment, but pre-approving 🙌
…rns-based-on-the-products-beta-block-with-an-equivalent-based-on-the-product-collection-block
…rns-based-on-the-products-beta-block-with-an-equivalent-based-on-the-product-collection-block
nefeline
deleted the
11132-store-customization-replace-all-patterns-based-on-the-products-beta-block-with-an-equivalent-based-on-the-product-collection-block
branch
October 5, 2023 08:36
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: product collection
Issues related to the Product Collection block
focus: patterns
WooCommerce patterns
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
On this PR, four patterns that originally relied on the now-retired Products (beta) block were replaced with an equivalent based on the new Product Collection block.
In addition to the block replacement, the width for all patterns was changed from none to wide so it complies with the expected for the templates within the pattern assembler.
Fixes #11132
Why
We need to ensure the new Product Collection block is used to compose the patterns within the Assembler.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
WooCommerce Visibility
Required:
Checklist
Required:
[type]
label or a[skip-changelog]
label.Conditional:
[skip-changelog]
label is not present).Changelog