This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Store Customization > Homepage Template 3: Review layout and spacing in between patterns #11131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
added
skip-changelog
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
I know it's still in draft but imo this deserves a changelog since it impacts (positively) the users experience. The only times I think changelogs should be omitted are for build/deployment related changes which don't impact the UX 😄 |
|
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
albarin
removed
the
skip-changelog
albarin
changed the title
albarin
changed the title
|
@albarin looks like there's some conflicts to solve here. |
albarin
force-pushed
the
11090/homepage-3-template
branch
from
5104a4b to
921ade5
Compare
Thanks @tjcafferkey, just pushed again resolving them 😄 |
|
Thanks for this @albarin the spacing is consistent between the patterns and the additional elements have been added which I can confirm. The only thing I notice are the same things @nefeline has noticed here #11129 (comment) with regards to image aspect ratio's and pagination. I know you have some thoughts on how you'd like to handle these based on your reply in the linked PR. I assume it's similar in this case also? |
Yes, it's the same, I'll tackle those on another PR 🙂 |
tjcafferkey
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Thanks for addressing, and for confirming you'll follow up to fix the issues highlighted here #11129 (comment)
albarin
force-pushed
the
11090/homepage-3-template
branch
from
de0ebce to
ff02824
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR:
Product Collection: Featured Products 5 Columns.Product Galleryone.Fixes #11090
Why
To adapt to the designs shown on #11090
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Featured Products 5-Item Gridcorresponds toProduct Collection: Featured Products 5 Columns)Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog