This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add data-price button attribute containing product price #11117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
message-dimke
added
type: enhancement
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
ralucaStan
requested review from
a team and
albarin
and removed request for
a team and
ralucaStan
albarin
approved these changes
Oct 9, 2023
|
Bumping PR to next release. |
|
Since this is already approved, I will merge and put it in current release. |
roykho
pushed a commit
that referenced
this pull request
Oct 9, 2023
* Add data-price button attribute containing product price * Fix phpcs error. --------- Co-authored-by: Dima <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11116
Why
Add to cart button
data-priceattribute is used by trackers e.g. Pinterest Tag tracker to report store visitor's events.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Expected value is not
nullChangelog