This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[Store Customization MVP] Fix conflict with other plugins #11082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
albarin
added
type: bug
|
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
nefeline
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Great work @albarin 🚀 !
@adrianduffell @chihsuan heads up that the expected response from the patterns endpoint was changed here from object to array, in case you need to adjust things on the client (JS) side for the Assembler.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes a PHP error that was occurring when the
WooCommerce Product Add-onsor theWooCommerce Product Bundlesplugins were enabled.Fixes #11040
Why
Both plugins are using the
rest_request_after_callbacksfilter and accessing the response data as an array but we were returning and object.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Create a new JN install with both Jetpack and Woocommerce installed and activated.
Install and activate WooCommerce Blocks from this zip file: [woocommerce-gutenberg-products-block.zip]
(https://wcblocks.wpcomstaging.com/wp-content/uploads/woocommerce-gutenberg-products-block-11082.zip), also install and enable the
WooCommerce Product Add-onsor theWooCommerce Product Bundles.In your wp-admin, set up the JetPack connection, make sure it's successful.
From your admin screen, click on Tools > Plugin editor:
Select the WooCommerce Blocks plugin and add the following within your woocommerce-blocks/woocommerce-gutenberg-products-block.php file and save:
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog