This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Ensure input is validated when autofilled in Firefox #11062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
type: bug
woocommercebot
requested review from
a team and
tarunvijwani
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.53 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
@opr Thank you for working on it. The changes looks good. However, I couldn't test the PR. For some reasons, the address field is getting disabled for me. I tried commenting out the ValidateInput to check if it is caused by this change but no dice. It's happening on trunk as well. Maybe something wrong with my local. I'll test the PR again tomorrow.
Here is the screen recording:
Screen.Recording.2023-09-29.at.12.30.32.AM.mov
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
opr
force-pushed
the
fix/firefox-autofill
branch
from
6658cbd to
f32d116
Compare
There was a problem hiding this comment.
@opr Thank you for the change! The input validation error has been resolved.
Repeat again without closing the window, when you load the Checkout block the second time, the details should be auto filled based on your last order.
When I was trying to order again, it already had a saved address. We might need to update the testing instructions or find another way to test this.
github-actions
bot
removed
the
status: stale
opr
force-pushed
the
fix/firefox-autofill
branch
from
f32d116 to
5e34e0f
Compare
This was referenced Nov 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ensures the
validateInputfunction is fired when aValidatedTextInputgets its value autofilled in Firefox.Why
For some reason there seems to be a race condition where inputs get validated before the
useEffectthat handles autofill/direct changes to the data store in Chrome. This PR causes validation to run when the input is updated via data store or autofill.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Perform these steps both in Firefox and Chrome/Brave/Edge
Screenshots or screencast
n/a
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog