This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add pattern chooser in Product Collection #10876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
added
type: enhancement
kmanijak
changed the title
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/product-collection/inspector-controls/columns-control.tsx
assets/js/blocks/product-collection/toolbar-controls/pattern-selection-modal.tsx |
|
Size Change: +642 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Patterns can be changed no matter if the Inherit Query from Template option in enabled or not
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
gigitux
approved these changes
Sep 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds the Pattern Chooser to Product Collection. Patterns that are currently available in Product Collection are purely UI patterns.
That means when you choose some pattern, then layout settings (grid vs list, number of columns, number products per page, pages, offset) are taken from the pattern and they override the current setup. But all the other query attributes are preserved, so changing the pattern doesn't influence the filters that are applied to Product Collection block.
Additionally:
DisplayLayoutToolbarhas been moved from Inspector Controls to Block ControlsFixes #9372
Why
It allows to change patterns from the Block Controls.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
patterns-demo.mov
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog