This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Update WooCommerce Blocks brand assets #10622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcafferkey
added
skip-changelog
PRs that you don't want to appear in the changelog.
type: task
The issue is an internally driven task (e.g. from another A8c team).
labels
Aug 16, 2023
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
August 16, 2023 13:09
albarin
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
The release ZIP for this PR is accessible via:
TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
Since these are WP.org asset updates only I don't think we need to wait for E2E tests. Merging anyway. |
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
nielslange
pushed a commit
that referenced
this pull request
Aug 17, 2023
nielslange
added a commit
that referenced
this pull request
Aug 17, 2023
* Empty commit for release pull request * Fix "On sale" badge class (#10634) * Fix "On sale" badge class for shop * Add class to sale badge * Remove client side navigation from Products beta block (#10636) * Remove client side navigation from Products beta block Changes: - Removed the `add_navigation_id_directive` method and its associated filter. This method previously added a `data-wc-navigation-id` attribute to the query block for client-side navigation, which is no longer required. - Removed the `add_navigation_link_directives` method and its associated filter. This method previously added interactive directives to pagination links inside the Query Pagination block. This specific functionality has been removed as it is no longer needed. - Introduced a new method `mark_block_as_interactive`, which is designed to mark the Product Query as an interactive region so that interactive elements can work inside it. This is achieved using the 'data-wc-interactive' attribute. * add data-wc-interactive to product button block * Remove unnecessary code As we have added `data-wc-interactive` on Product button therefore we don't need to add it in Product Query block. * Boolean attribute doesn't need explicit value equal to true * Skip failing i18n-related E2E tests * Skip failing i18n-related E2E test --------- Co-authored-by: Luigi <[email protected]> Co-authored-by: Niels Lange <[email protected]> * Update WooCommerce Blocks brand assets (#10622) --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Alba Rincón <[email protected]> Co-authored-by: Manish Menaria <[email protected]> Co-authored-by: Luigi <[email protected]> Co-authored-by: Niels Lange <[email protected]> Co-authored-by: Tom Cafferkey <[email protected]>
thealexandrelara
added a commit
that referenced
this pull request
Aug 24, 2023
* Empty commit for release pull request * Fix "On sale" badge class (#10634) * Fix "On sale" badge class for shop * Add class to sale badge * Remove client side navigation from Products beta block (#10636) * Remove client side navigation from Products beta block Changes: - Removed the `add_navigation_id_directive` method and its associated filter. This method previously added a `data-wc-navigation-id` attribute to the query block for client-side navigation, which is no longer required. - Removed the `add_navigation_link_directives` method and its associated filter. This method previously added interactive directives to pagination links inside the Query Pagination block. This specific functionality has been removed as it is no longer needed. - Introduced a new method `mark_block_as_interactive`, which is designed to mark the Product Query as an interactive region so that interactive elements can work inside it. This is achieved using the 'data-wc-interactive' attribute. * add data-wc-interactive to product button block * Remove unnecessary code As we have added `data-wc-interactive` on Product button therefore we don't need to add it in Product Query block. * Boolean attribute doesn't need explicit value equal to true * Skip failing i18n-related E2E tests * Skip failing i18n-related E2E test --------- Co-authored-by: Luigi <[email protected]> Co-authored-by: Niels Lange <[email protected]> * Update WooCommerce Blocks brand assets (#10622) * Update testing instructions * Update changelog * Fix version number of testing instructions * Update testing notes * Update testing ZIP file * Update version number * Empty commit for release pull request * Load Interactivity API in `bootstrap.php` (#10657) * load Interactivity API in Bootstrap.php file * fix comment * update visibility function * remove blank line * remove comment * remove logic to not load Interactivity API * Empty commit for release pull request * Add readme file * Update testing instructions * Change versions * Update zip * Update 1092.md * Update 1092.md * Make View Cart link displayed below the Add to Cart button (#10675) * Update testing instructions * Update testing notes * Fix: Made migration migrate block templates in the current theme (#10641) * Fix: Made migration migrate block templates in the current theme * Update src/BlockTemplatesController.php Co-authored-by: Paulo Arromba <[email protected]> * Move migration and status codes to BlockTemplateMigrationUtils --------- Co-authored-by: Paulo Arromba <[email protected]> * Fix: sync_endpoint_with_page should use a matching slug if it exists instead of creating a new page (#10640) * Fix/10530 Inconsistent new install behaviour for templates when using block themes (#10608) * Skipped requests regarding WP/WC setup, to avoid issues with the pages not existing yet when migrating page content to templates. * Skipped requests regarding WP-CLI to avoid issues with the pages not existing yet when migrating page content to templates. * Added check for woocommerce_db_version option * Add check for occurred migration to skip template injection * corrected if clause * Update src/BlockTemplatesController.php Co-authored-by: Mike Jolley <[email protected]> * Added maintenance mode to migration exception. Added trace value to has_migrated options * Merge with new migration logic. * Set correct post terms for wp_template content * updated comment --------- Co-authored-by: Mike Jolley <[email protected]> * Update ZIP file * Update testing notes * Update testing notes * Update testing notes * Update testing notes * Update woocommerce.zip file * Revert "Fix: sync_endpoint_with_page should use a matching slug if it exists instead of creating a new page (#10640)" This reverts commit c68583b. * Update testing notes * Update ZIP file * Update changelog * Empty commit for release pull request * Add changelog to readme.txt * Update plugin version in several files * Revert dequeue add-to-cart-variation script which is needed to properly handle variable products in single product page (#10723) * Add the testing notes for 10.9.3 * Update 1093.md * Fix md lint error --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Alba Rincón <[email protected]> Co-authored-by: Manish Menaria <[email protected]> Co-authored-by: Luigi <[email protected]> Co-authored-by: Niels Lange <[email protected]> Co-authored-by: Tom Cafferkey <[email protected]> Co-authored-by: Karol Manijak <[email protected]> Co-authored-by: Mike Jolley <[email protected]> Co-authored-by: Paulo Arromba <[email protected]> Co-authored-by: Alexandre Lara <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
skip-changelog
PRs that you don't want to appear in the changelog.
type: task
The issue is an internally driven task (e.g. from another A8c team).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the branding assets for the plugin used on WordPress.org plugin directory.
Fixes #
Accessibility
prefers-reduced-motion
Other Checks
[type]
label or a[skip-changelog]
label.Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog