This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Store Customization > Add an identifier to all footer patterns #10542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nefeline
changed the title
Store Customization > Add an identifier to all header patterns
Store Customization > Add an identifier to all footer patterns
Aug 11, 2023
woocommercebot
requested review from
imanish003
and removed request for
a team
August 11, 2023 09:18
nefeline
added
type: enhancement
The issue is a request for an enhancement.
▫️ pattern: footers
labels
Aug 11, 2023
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
imanish003
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I've verified all the patterns, and each of them contains the wc-blocks-footer-pattern
class. 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the Pattern Assembler project, the Guidorah team needs to enable a feature to select patterns already inserted in the editor and replace them with other patterns whenever users browse through all options on the sidebar.
To facilitate this task, the
wc-blocks-footer-pattern
class identifier is being added to all footer patterns.Fixes #10539
Testing
User Facing Testing
wc-blocks-footer-pattern
class in all footer patterns:WooCommerce Visibility
Changelog