This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix express button display in the Cart block #10534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralucaStan
added
the
status: blocker
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +12 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
nielslange
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Thanks for working on this, @ralucaStan. The fix works as expected.
While reviewing this PR, I did notice the following things:
- The labels ◼️ block: cart and ◼️ block: checkout are missing
- "WooCommerce Visibility" hasn't been defined
- Either the changelog message or the label skip-changelog is missing
- One E2E test is currently failing
That said, as the fix itself is working as expected, I'm preapproving this PR.
ralucaStan
added
block: cart
ralucaStan
force-pushed
the
fix/cart-express-payments-display
branch
2 times, most recently
from
d9b9626 to
1e1841a
Compare
When multiple buttons are displayed they don't appear stacked. This PR fixes a regression;
ralucaStan
force-pushed
the
fix/cart-express-payments-display
branch
from
1e1841a to
bb68d53
Compare
|
@nielslange thank you for checking the PR description 👏 I updated that. 
Could you also retest the buttons in the editor? I found a bug in the editor that I just fixed in a second commit.
Aparently moving the class decreased the specificity and the ul tag received some editor padding |
Can you tell me with which theme the padding issue appeared? I'm asking as I didn't see the padding issue during my initial review. |
|
I was using Storefront, without Gutenberg |
While the PR works as expected when using the Storefront theme, when using the Twenty Twenty-Three theme, the Express Checkout inner block shows an error, both when Gutenberg is activated and deactivated. 
The console shows the following error message: |
|
@nielslange This PR only introduces CSS changes. Can you replicate this issue with |
|
As I've mentioned outside of this PR I can't replicate the issue 
If you can't replicate the error on trunk as well then it means the issue is coming from this branch and I would need detailed replication steps to be able to understand your setup better. |
opr
approved these changes
Aug 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in #8601;
The above PR set a grid display for the express payments area for the Checkout block; that component was reused in the Cart block as well leading to visual bugs
This PR sets the grid layout only for the Checkout block
Fixes #10528
Accessibility
prefers-reduced-motionOther Checks
[type]label or a[skip-changelog]label.Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog