This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Revert "Performance: Cache script data in a transient for production builds" #10509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
woocommercebot
requested review from
a team and
kmanijak
and removed request for
a team
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
gigitux
changed the title
imanish003
approved these changes
Aug 9, 2023
gigitux
added a commit
that referenced
this pull request
Aug 9, 2023
* Revert "Performance: Cache script data in a transient for production builds" (#10509) * Revert "Performance: Cache script data in a transient for production builds (#9120)" This reverts commit 6b9955d. * fix WordPress version * fix version * update version to 10.6.5 * update changelog and testing instructions * update zip link * fix changelog --------- Co-authored-by: Luigi Teschio <[email protected]>
Merged
gigitux
added a commit
that referenced
this pull request
Aug 9, 2023
* Revert #10509 (#10513) * Revert "Revert "Performance: Cache script data in a transient for production builds" (#10509)" This reverts commit d5f786e. * keep WP 6.2.2 as env to run E2E tests * Empty commit for release pull request * update changelog and testing instructions * bump version to 10.8.2 * update zip link --------- Co-authored-by: Luigi Teschio <[email protected]> Co-authored-by: github-actions <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes woocommerce/woocommerce#39633.
Also, this PR sets the version of WordPress for the E2E env to 6.2.2.
This reverts commit 6b9955d (#9120)
#9120 stores in the cache the plugin version, the protocol (http or https) and the domain. This causes an issue when the url change. (for example the url switch from http to https).
Fixes woocommerce/woocommerce#39633.
Testing
Automated Tests
User Facing Testing
Performance Impact
Changelog