This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Unify links to WordPress and WooCommerce websites in patterns #10380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
roykho
and removed request for
a team
Aljullu
added
status: needs review
type: enhancement
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -14 kB (-1%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
roykho
suggested changes
Jul 27, 2023
roykho
approved these changes
Jul 28, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies the way we link to WordPress and WooCommerce websites in patterns following these rules:
target="_blank"andrel="noreferrer nofollow"to all links (I used a similar PR in Storefront for inspiration: Updates Storefront Credit in the footer for SEO. storefront#2096).esc_html().WordPressandWooCommerceto the untranslatable part of the string. I don't have a strong preference on this, but wanted to unify to one approach and used this as a reference. This also gives us the benefit to be able to useesc_html()instead ofwp_kses().Testing
User Facing Testing
WooCommerce Visibility
Changelog