This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Check if index element exists before using for Product Collection #10300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roykho
added
type: bug
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
danieldudzic
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
I am happy I have stumbled across this PR. I will now update my Product Gallery Thumbnails PR that has the same exact issue with not checking if the context exists first.
I have tested this, and it indeed gets rid of the Undefined array key warnings.
The only thing I'd recommend is updating the title of the PR and perhaps mentioning that this relates to the context. And perhaps adding a short description in the body/comment on top.
kmanijak
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Thanks @roykho for taking care of that issue!
Product Collection is still experimental, hence could you please:
- Change the "WooCommerce Visibility" to "Experimental"
- Mark "Do not include in the Testing Notes"?
While this solution is valid I'm still wondering why Product Collection/Product Template tries to render inner blocks like Product Button or Image, while there's no results to display 🤔
roykho
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10232
Testing
User Facing Testing
Products (beta)block and replace withProduct Collectionblock. Make sure to have "Inherit query from template" option enabled. Save.WooCommerce Visibility
Performance Impact
Changelog