This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove opinionated styles from Alternating Image and Text pattern #10292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
type: enhancement
woocommercebot
requested review from
a team and
thealexandrelara
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
thealexandrelara
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
I used images with different sizes and this is the result:
I think you used square images for the "after" image, so just confirming that the images should maintain their aspect ratio (like in the image above) instead of being squared when using images with different sizes for the height and width
Other than that, code looks good and everything is working as expected, so I'm pre-approving this PR! 🚀
|
Thanks for the review @thealexandrelara!
Good question. I'm going to ping @jarekmorawski about this. tl;dr Should we default to a square aspect ratio in the images of the Alternating Image and Text pattern? |
|
I think it's okay to default to square as long as the user can change the position in the inspector, similar to how they can do it in the Cover block. 
|
|
Unfortunately, that's not possible with the Image block: 
In that case, should we not have an aspect ratio by default and simply honor the existing aspect ratio of the image, @jarekmorawski? Users can still easily modify the aspect ratio in the sidebar if they want. |
|
In that case, yes, we should keep the original aspect ratio. Thanks for looking into it, Albert! 🙏 |
|
Makes sense. Thanks for your input, @jarekmorawski! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10290.
Testing
User Facing Testing
Desktop:
WooCommerce Visibility
Changelog