This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add to Cart Form: Fix broken styles for the block when using inside the Single Product Block #10282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thealexandrelara
added
type: bug
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
thealexandrelara
force-pushed
the
fix/broken-styles-for-add-to-cart-form-block-when-inside-single-product-block
branch
from
39c6637 to
1e60e1f
Compare
|
Size Change: +783 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
albarin
approved these changes
Jul 20, 2023
thealexandrelara
deleted the
fix/broken-styles-for-add-to-cart-form-block-when-inside-single-product-block
branch
Merged
gigitux
pushed a commit
that referenced
this pull request
Aug 2, 2023
…he Single Product Block (#10282) * Fix broken styles for Add to Cart Form block * Fix PHP CS error
gigitux
added a commit
that referenced
this pull request
Aug 3, 2023
* improve migration to blockified templates (#10415) * Add to Cart Form: Fix broken styles for the block when using inside the Single Product Block (#10282) * Fix broken styles for Add to Cart Form block * Fix PHP CS error * add testing instructions * Empty commit for release pull request * update changelog * update version * add zip link * improve testing instructions --------- Co-authored-by: Luigi Teschio <[email protected]> Co-authored-by: Alexandre Lara <[email protected]> Co-authored-by: github-actions <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the Single Product block with WordPress 6.3 I noticed that the styles for the Add to Cart Form block were not being applied correctly. The input was too small and there was a line break between the input and the button.
Walkthrough
🤖 Generated by Copilot at 1e60e1f
Accessibility
prefers-reduced-motionOther Checks
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog