This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add missing page titles in Cart and Checkout templates #10281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
type: bug
woocommercebot
requested review from
a team and
tarhi-saad
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
nielslange
commented
Jul 20, 2023
nielslange
added
the
focus: i18n
wavvves
reviewed
Jul 20, 2023
|
Thanks for your review, @wavvves. Would you mind giving it another look? |
nielslange
force-pushed
the
add/10171-missing-page-titles-in-cc-templates
branch
from
fce5417 to
71cab56
Compare
wavvves
approved these changes
Jul 21, 2023
|
Thanks for your review, @wavvves! 🙌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10171
In WooCommerce Blocks 10.6.0, we introduced the Cart and Checkout templates. Initially, we introduced them without the page title. This led to failing e2e tests and confusion as other pages do have a page title. This PR aims to add the page titles to the Cart and Checkout templates.
Screenshots
Testing
User Facing Testing » Verify that page titles are visible
Cart.Checkout.Cart.Checkout.User Facing Testing » Verify that page titles are translatable
/wp-admin/options-general.phpand switch the language toNederlands./wp-admin/update-core.phpand fetch the available translations.Winkelwagen.Afrekenen.Winkelwagen.Afrekenen.WooCommerce Visibility
Changelog