This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove opinionated styles from Hero Product 3 Split pattern #10260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
type: enhancement
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
Aljullu
commented
Jul 18, 2023
| <div class="wp-block-group" style="margin-top:20px;margin-bottom:20px;padding-top:0;padding-right:20px;padding-left:20px"> | ||
| <!-- wp:heading {"style":{"typography":{"fontStyle":"normal","fontWeight":"700"}},"fontSize":"large"} --> | ||
| <h2 class="wp-block-heading has-large-font-size" style="font-style:normal;font-weight:700">Endless Tee's</h2> | ||
| <!-- wp:group {"style":{"spacing":{"margin":{"top":"20px","bottom":"20px"}}},"layout":{"type":"flex","orientation":"vertical"}} --> |
There was a problem hiding this comment.
I don't think we can get rid of these margins. Doing so causes the text in the black box to collide withe border.
Aljullu
commented
Jul 18, 2023
| <!-- wp:column {"verticalAlignment":"center","width":"33.33%"} --> | ||
| <div class="wp-block-column is-vertically-aligned-center" style="flex-basis:33.33%"> | ||
| <!-- wp:paragraph --> | ||
| <p><strong><?php esc_attr_e( 'Waterproof Membrane', 'woo-gutenberg-products-block' ); ?></strong></p> |
There was a problem hiding this comment.
I converted these headings into paragraphs; otherwise they would look huge.
|
The release ZIP for this PR is accessible via: TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10217.
Testing
User Facing Testing
WooCommerce Visibility
Changelog