This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove styles from the Testimonials 3 cols pattern
#10258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +2.03 kB (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
albarin
force-pushed
the
10218/testimonial-3-col-wireframe
branch
from
1c98835 to
19d1e61
Compare
woocommercebot
requested review from
a team and
thealexandrelara
and removed request for
a team
Aljullu
reviewed
Jul 18, 2023
There was a problem hiding this comment.
Overall looks good, but I see in the designs there is now a product image and a product name next to the reviewer name.
However, thinking about this, I'm not sure if we should add those elements. Currently those testimonials are hard-coded instead of being real ones, so adding a product image and a product name makes this pattern more difficult to adapt IMO. What do you think? cc @albarin @jarekmorawski
I didn't address those changes because on the task it says: |
Aljullu
approved these changes
Jul 19, 2023
imanish003
added
the
type: enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10218
Screenshots
Testing
User Facing Testing
Testimonials 3 columnspattern.Afterscreenshot above.WooCommerce Visibility
Performance Impact
Changelog