This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add class specificity to fix indent #10245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roykho
added
type: bug
woocommercebot
requested review from
a team and
danieldudzic
and removed request for
a team
|
The release ZIP for this PR is accessible via: TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
|
Size Change: +31 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
danieldudzic
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
The fix works correctly. I have tested with:
Filter by Attributes, Featured Category, Featured Product, Hand-picked Products, Reviews by Product, Reviews by Category.
Out of curiosity: Do we know when the regression happened? Or was it there since the beginning?
I have also noticed two unrelated issues when testing:
-
When in "Pencil" mode, it seems that the selection in a different block, cancels out the selection:
-
A list styling issue for the multiple selection blocks:
I have searched in our repo but wasn't able to find any relevant issues. Do you know if these are known issues, or should I report them?
Yes any issues you find should definitely be reported. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10110
This PR fixes an indent issue when using the Storefront theme for the search list control.
Screenshots
Testing
User Facing Testing
Filter by Attributes,Featured Category,Featured Product,Hand-picked Products,Reviews by Product,Reviews by Category.afterscreenshot. Another words there should be no indentation.WooCommerce Visibility
Performance Impact
Changelog