This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Automatic migration path from Products to Product Collection - step 3 - allow reverting migration #10144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to Product Collection
kmanijak
added
skip-changelog
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/shared/scripts/migration-from-product-collection-to-products.tsx
|
|
Size Change: +839 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
14 tasks
… into add/migration-path-from-products-step-3-revert
Base automatically changed from
add/migration-path-from-products-step-2-display-notice
to
trunk
July 12, 2023 09:19
gigitux
approved these changes
Jul 12, 2023
I agree, I mentioned that in scope of: #10139:
What's your opinion? Should I add a fix within our repo? |
Thanks for the clarification! Let's merge as it is! 🚢 |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third PR out of many that introduce automatic migration from Products to Product Collection blocks.
This PR adds a logic that allows to reverting automatic migration from Product (Beta) block to Product Collection.
Part of #9703
For more context, check out:
Testing
Automated Tests
User Facing Testing
Below you can find testing steps with multiple different scenarios. I didn't write detailed testing steps on how to change the settings of Products (Beta) block to keep it clean. However, if you're not familiar with these settings I recorded a video showcasing each of them, so please use it as a reference point. Video is split and attached to each section respectively.
Go to Editor and edit for example Product Catalog
Add Products (Beta) block with different settings/configurations/scenarios etc.:
PRODUCTS SET
inherits the query from the template
doesn't inherit the query from the template and has some filters applied (e.g. products on sale, handpicked products etc.). You can try multiple combinations that result in various set of product
My.Movie.mp4
LAYOUT
has "grid" layout and custom number of "columns", for example, 5
has "list" layout and custom number of "items per page", for example, 6
check with Gutenberg version below 16 (the layout was controlled on Query Loop level)
check with Gutenberg version 16+ (the layout properties were moved from Query Loop to Post Template block)
code-review-layout.mp4
PRODUCT ELEMENTS
change product template by adding additional elements and changing order (e.g. add Product Rating, Product SKU etc.) and change order of them
change "No Results" content
code-revbiew-template.mp4
STYLING
change styles on the "Product Template" level, for example color and background color
change styles of some Product Elements
styling.mp4
POSITION IN BLOCK STRUCTURE
nest Products (Beta) block inside other blocks (e.g. Group, Columns etc.)
OTHERS
Suggest your own combination or edge cases of settings that should be preserved during migration
Save the above
Change the REPLACE_PRODUCTS_WITH_PRODUCT_COLLECTION variable to
true- replacement will be enabled for the next entries to the editorRefresh the Editor
Expected: All of the Products (Beta) blocks should be replaced with Product Collection block and preserve all of the configuration (Products Set, Layout, Product Elements, Styling, Position in blocks structure and Others)
Focus on one of the Product Collection blocks
Click "Revert to Products (Beta)"
Expected: All of the Product Collection blocks should be replaced back with Products (Beta) block and preserve all of the configuration (Products Set, Layout, Product Elements, Styling, Position in blocks structure and Others)
replacement.mp4
WooCommerce Visibility