This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix cart and checkout conditionals when using a block based theme and templates #10098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
status: needs review
skip-changelog
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +1.13 kB (0%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
opr
approved these changes
Jul 5, 2023
opr
pushed a commit
that referenced
this pull request
Jul 5, 2023
… templates (#10098) * Update conditionals to deal with templates instead of cart/checkout page objects * Include notice style in main entrypoint
opr
added
the
release: cherry-pick
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes both new notice styling, and some shipping settings, that were relying on the cart and checkout pages to see if those features should be enabled. This adds a check to instead see if there is a FSE theme in use, in which case it checks the templates instead.
Testing
Automated Tests
User Facing Testing