This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Make filter by rating preview consistent with default settings #10007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roykho
added
type: bug
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +1.68 kB (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
imanish003
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Hi @roykho, I tested the PR and it's working as expected. 🚀
I left one minor suggestion. Also, I noticed that the UI isn't looking as expected. In the screenshot you can see that the number of faded stars is not correct. Since we are providing ratings from 5 to 1, the second row should have 1 faded star at the end, the third row should have 2 faded stars at the end, and so on.
Although I don't think this falls within the scope of the current PR, I am pre-approving it. However, feel free to work on fixing the UI in this PR or we can create a new task for it. 🙂
|
Hi @imanish003 - I've removed the |
|
Hi @roykho, I just confirmed that disabling Gutenberg fixes the issue. Thank you for explaining it to me. The changes you made look good to me. Well done! 🚀 🚢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9958
This PR updates the preview to be consistent with default settings.
Screenshots
Testing
User Facing Testing
Filter by Ratingblock.Display Product countsetting is disabled.WooCommerce Visibility
Performance Impact
Changelog