Display special characters when they are part of a city name

[nielslange]

Problem

In #8531, @Moosinams mentioned that some Dutch cities can start with a single quote, for example 's-Hertogenbosch. While it's possible to place an order with 's-Hertogenbosch as city name, when placing a second order, the city name ‘s-Hertogenbosch appears in the Checkout block.

Steps to reproduce

1. Add a product to the cart.
2. Go to the checkout.
3. Place the order with the following address:

Address         : Stationsplein 151
Country/Region  : Nederland
Postal code     : 5211 BP
City            : 's-Hertogenbosch

4. Place another order.
5. Verify that the prefilled city name appears as ‘s-Hertogenbosch.

Additional cities that start with an apostrophe:

• ’s-Gravenhage (The Hague) - Netherlands
• ’s-Hertogenrade - Netherlands
• ’s-Heerenberg - Netherlands
• ’s-Heer Abtskerke - Netherlands
• ’s-Heer Arendskerke - Netherlands
• ’s-Heerenhoek - Netherlands
• ’s-Heer Hendrikskinderen - Netherlands

[wavvves]

@nielslange In my opinion, we shouldn't prevent data from being escaped. Instead, decode the HTML entities or make sure the browser can parse them properly for displaying. It's highly likely this problem affects other fields 🤔

[Moosinams]

Dear Niels, Sorry to aks you in this way. I have a problem with the checkout-page. It gives error; invalid parameter owner[name]. Owner name must be at least 3 characters long. Hope you could help me using my email. I find it to difficult to pass it on github. Greetings Moos [image: Schermafbeelding 2023-04-11 om 10.58.14.jpg] Op vr 24 feb 2023 om 13:03 schreef Niels Lange ***@***.***>:

…

Problem In #8531 <#8531>, @Moosinams <https://github.com/Moosinams> mentioned that some Dutch cities can start with a single quote, for example 's-Hertogenbosch. While it's possible to place an order with 's-Hertogenbosch as city name, when placing a second order, the city name &#8216;s-Hertogenbosch appears in the Checkout block. Steps to reproduce 1. Add a product to the cart. 2. Go to the checkout. 3. Place the order with the following address: Address : Stationsplein 151 Country/Region : Nederland Postal code : 5211 BP City : 's-Hertogenbosch 1. Place another order. 2. Verify that the prefilled city name appears as &#8216;s-Hertogenbosch. — Reply to this email directly, view it on GitHub <#8533>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6DF7FZURKUUDNBA423QITLWZCPPVANCNFSM6AAAAAAVG2EJOQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[nielslange]

@nielslange In my opinion, we shouldn't prevent data from being escaped. Instead, decode the HTML entities or make sure the browser can parse them properly for displaying. It's highly likely this problem affects other fields 🤔

Good point, @wavvves. My primary intension was to ensure that city names with special characters are displayed correctly. I changed the title of this issue accordingly.

[nielslange]

Dear Niels, Sorry to aks you in this way. I have a problem with the checkout-page. It gives error; invalid parameter owner[name]. Owner name must be at least 3 characters long. Hope you could help me using my email. I find it to difficult to pass it on github. Greetings Moos

Hello @Moosinams 👋

To avoid confusion, please create a separate issue for your question.

[dnusca]

I'd like to pick this one up!

[dnusca]

@nielslange I'm wondering at what level in the component hierarchy the HTML entities should be decoded?

We've got:

• AddressForm
  -- ValidatedTextInput
  --- TextInput

I was going to decode the entities inside TextInput, but might there be a use case for displaying encoded html entities in a TextInput?

[nielslange]

[...] I'm wondering at what level in the component hierarchy the HTML entities should be decoded?

Thanks for reaching out, @dnusca. Given the component hierarchy, decoding the HTML entities inside the TextInput component would be appropriate. This follows the general principle from both WordPress.org and WordPress VIP guidelines to escape data as late as possible.

[dnusca]

Thanks. I've submitted a PR with the changes in the TextInput

[Moosinams]

Tnx for your help. Moos Op wo 19 apr. 2023 om 18:53 schreef Paulo Arromba ***@***.***>

…

Closed #8533 <#8533> as completed via #9117 <#9117>. — Reply to this email directly, view it on GitHub <#8533 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6DF7F2S2TCQZZ3F2NMJOIDXCAKBJANCNFSM6AAAAAAVG2EJOQ> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>