Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Filter blocks with dropdown display style should also show the chevron when Single selection is enabled #8075

Closed
Aljullu opened this issue Jan 2, 2023 · 0 comments · Fixed by #8080
Assignees
Labels
block: filter by attribute Issues related to the Filter by Attribute block. block: filter by rating Issues related to the Filter by Rating block. block: filter by stock Issues related to the Filter by Stock block. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Jan 2, 2023

To reproduce

  1. Create a post or page with the Filter by Stock, Filter by Rating and Products blocks.
  2. Select the Filter by Stock Controls block and choose: Single and Dropdown in the Display Settings.
  3. Select the Filter by Rating Controls block and choose: Multiple and Dropdown in the Display Settings.
  4. Go to the frontend.
  5. Notice the Filter by Stock dropdown doesn't have a chevron on the right, while the Filter by Rating block does have it.

Expected behavior

Both dropdowns should display the chevron to signal to the user that clicking on them will open a list of suggestions.

Additional context

The relevant code can be found here:

{ multiple && (
<Icon icon={ chevronDown } size={ 30 } />
) }

@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. block: filter by attribute Issues related to the Filter by Attribute block. block: filter by stock Issues related to the Filter by Stock block. block: filter by rating Issues related to the Filter by Rating block. labels Jan 2, 2023
@danieldudzic danieldudzic self-assigned this Jan 3, 2023
danieldudzic added a commit that referenced this issue Jan 4, 2023
…display (#8080)

* Filter blocks: Fix the dropdown indicator icon display for 'single option' mode. Closes #8075

* Filter blocks: Fix the dropdown indicator for multiple items option. Closes #7889
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: filter by attribute Issues related to the Filter by Attribute block. block: filter by rating Issues related to the Filter by Rating block. block: filter by stock Issues related to the Filter by Stock block. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
2 participants