Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Cart/Checkout resource hinting should be limited to only if you're running those blocks. #7216

Closed
senadir opened this issue Sep 23, 2022 · 2 comments · Fixed by #7364
Closed

Cart/Checkout resource hinting should be limited to only if you're running those blocks. #7216

senadir opened this issue Sep 23, 2022 · 2 comments · Fixed by #7364
Assignees
@mikejolley
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. type: bug The issue/PR concerns a confirmed bug.

Comments

@senadir
Copy link
Member

senadir commented Sep 23, 2022

In 7.3.0, we added resource hinting to Cart/Checkout assets, however, the condition to add this hinting is if you have a valid cart, but it's kind of useless (and counter productive) if you're not running Cart block or Checkout block, so we should skip it if someone isn't running those blocks as default.
@senadir senadir added the type: bug The issue/PR concerns a confirmed bug. label Sep 23, 2022
@danielwrobert danielwrobert added block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. labels Sep 23, 2022
@ralucaStan
Copy link
Contributor

This could be fixed together with #7215

@ralucaStan
Copy link
Contributor

Follow up of #7211

@ralucaStan ralucaStan mentioned this issue Oct 7, 2022
Closed
@mikejolley mikejolley self-assigned this Oct 11, 2022
mikejolley added a commit that referenced this issue Oct 11, 2022
@mikejolley
Output resource hinting only when using cart/checkout blocks on cart/…
e37cb98 
…checkout pages #7216
@mikejolley mikejolley mentioned this issue Oct 11, 2022
Merged
4 tasks
mikejolley added a commit that referenced this issue Oct 14, 2022
@mikejolley
Prevent resource hinting when cart/checkout blocks are not in use (#7364
93c80e9 
)

* Skip resource hinting on admin requests #7215

* Output resource hinting only when using cart/checkout blocks on cart/checkout pages #7216
sunyatasattva pushed a commit that referenced this issue Oct 26, 2022
@mikejolley @sunyatasattva
Prevent resource hinting when cart/checkout blocks are not in use (#7364
d8e2029 
)

* Skip resource hinting on admin requests #7215

* Output resource hinting only when using cart/checkout blocks on cart/checkout pages #7216
senadir pushed a commit to senadir/woocommerce-blocks that referenced this issue Nov 12, 2022
@mikejolley @senadir
Prevent resource hinting when cart/checkout blocks are not in use (wo…
721eb02 
…ocommerce#7364)

* Skip resource hinting on admin requests woocommerce#7215

* Output resource hinting only when using cart/checkout blocks on cart/checkout pages woocommerce#7216
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mikejolley mikejolley

Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent resource hinting when cart/checkout blocks are not in use woocommerce/woocommerce-blocks
4 participants
@mikejolley @danielwrobert @ralucaStan @senadir