This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Featured Items: Inline style color defaults override Global Styles #7042
Labels
block: featured category
Issues related to the Featured Category block,
block: featured product
Issues related to the Featured Product block.
type: bug
The issue/PR concerns a confirmed bug.
Summary
The text color defaults for the Featured Product and Featured Category blocks are set as inline styles. The problem is that the inline styles also override any changes to the block's Global Styles in the Site Editor.
To reproduce
Steps to reproduce the behavior:
Expected behavior
The text setting should also be adjustable when edited via Global Styles.
Screenshots
Additional context
The purpose for the inline default, as implemented in #6492, was to ensure the white text over the overlay, as some theme styles (i.e., Storefront) were potentially interfering.
Now that we have Block Themes and Global Styles becoming more prevalent, we should ensure that our blocks are editable via the controls offered. We can add an editor-specific style for added specificity but we do not want so much specificity that the Global Styles are overridden, as they are currently. IMO, the theme styles should be responsible to ensure they are not unintentionally overriding global settings.
cc @Aljullu and @sunyatasattva for your input, as you were both involved in #6489 and #6492.
The text was updated successfully, but these errors were encountered: