Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Featured Product and Featured Category blocks default colors don't have enough contrast #6489

Closed
Aljullu opened this issue May 30, 2022 · 3 comments · Fixed by #6492
Closed
Labels
block: featured category Issues related to the Featured Category block, block: featured product Issues related to the Featured Product block. type: bug The issue/PR concerns a confirmed bug.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented May 30, 2022

To reproduce

  1. Add a Featured Product or Featured Category block into a post or page.
  2. Notice text doesn't have enough contrast with the background.

imatge

Expected behavior

By default, we should make sure text and background have enough contrast.

@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. block: featured category Issues related to the Featured Category block, block: featured product Issues related to the Featured Product block. labels May 30, 2022
@Aljullu
Copy link
Contributor Author

Aljullu commented May 30, 2022

@sunyatasattva will you be able to take a look at this one? I think there wasn't this issue before. Maybe we should change the overlay default color?

@sunyatasattva
Copy link
Contributor

Sure, I'll look into it. Previously I think the default was white, so contrast worked well enough. Strange we didn't notice.

@sunyatasattva
Copy link
Contributor

Result of testing, as clarification for this issue: this seems to happen only when themes override blocks CSS. In this case, Storefront shows this problem, while most other themes I tested with do not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: featured category Issues related to the Featured Category block, block: featured product Issues related to the Featured Product block. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants