Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Store Editing Templates: Consider new block templates & block-template-parts directories #5450

Closed
tjcafferkey opened this issue Dec 23, 2021 · 0 comments · Fixed by #5455
Closed

Store Editing Templates: Consider new block templates & block-template-parts directories #5450

tjcafferkey opened this issue Dec 23, 2021 · 0 comments · Fixed by #5455
Assignees
@sunyatasattva
Labels
focus: FSE Work related to prepare WooCommerce for FSE. focus: template Related to API powering block template functionality in the Site Editor type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@tjcafferkey
Copy link
Contributor

Describe the bug

The new naming conventions set for FSE enabled themes now look for the templates html files in templates and parts. Tove is an example of a theme that uses these now.

We need to also check these directories in our code as well as the current block-templates and block-template-parts directories.

Note: There may be instances elsewhere in our BlockTemplating code where we look for these directories so please check.
@tjcafferkey tjcafferkey added type: bug The issue/PR concerns a confirmed bug. focus: FSE Work related to prepare WooCommerce for FSE. focus: template Related to API powering block template functionality in the Site Editor type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. labels Dec 23, 2021
@tjcafferkey tjcafferkey mentioned this issue Dec 23, 2021
Closed
sunyatasattva added a commit that referenced this issue Dec 24, 2021
@sunyatasattva
Move block templates and parts directories to the Gutenberg 12.1.0 co…
79671e6 
…nvention

Gutenberg 12.1.0 has changed the convention for the directory paths from
`block-templates` and `block-template-parts` to `templates` and `parts` respectively.

We are also moving to that convention but making sure that we remain
backwards-compatible.

Fixes #5450, #5343
@sunyatasattva sunyatasattva mentioned this issue Dec 24, 2021
Merged
1 task
sunyatasattva added a commit that referenced this issue Dec 28, 2021
@sunyatasattva
Move block templates and parts directories to the Gutenberg 12.1.0 co…
8d16ff2 
…nvention (#5455)

Gutenberg 12.1.0 has changed the convention for the directory paths from
`block-templates` and `block-template-parts` to `templates` and `parts` respectively.

Allow compatibility with themes which follow both conventions and also make sure that
we remain backwards-compatible.

Fixes #5450

Some of this fix has a dependency on WooCore

See: woocommerce/woocommerce#31522
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sunyatasattva sunyatasattva

Labels
focus: FSE Work related to prepare WooCommerce for FSE. focus: template Related to API powering block template functionality in the Site Editor type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Milestone
No milestone
2 participants
@sunyatasattva @tjcafferkey